Monday meeting notes for 8/10/2018

[Marco Martin]

present: Eike, David, Johnathan, Roman, Bhushan, Vlad, Marco

Eike:
* I've been quite busy with non-Plasma things, so my activity was limited to 
responding to code reviews and API changes and updating my Wayland VD Phabs
* I did another pass over the KCM based on Vlad's review comments before the 
meeting, will upload after dinner
* And then I'm kind of out of work on the VD stuff, so maybe it's merge time 
soon?

David:
* Qt 5.12 now works fine with kwin \o/
** required qt patches which are merged and one in kwin (downside of kwin 
having a QPA is we're liable to break every release with something)
* maximize effect now will work on wayland
* Fixed a bug in kwayland that means firefox gets slightly further (but still 
breaks)
* and I'm still continuing to chip away slowly at ksmserver
* this week will continue on kwin/wayland

Johnathan:
* tomorrow 5.14 release
* not sure we get a video this time

Roman:
-------------------------
What I did since last week:
-------------------------
* Needed some slower work time after my large Xwayland/input redirection 
rework patches in the last few months and XDC.
* Did research for input methods and our virtual keyboard. text-input v3 
protocol does not have huge changes, but I'm not yet sure how to deal with the 
abstraction in KWayland.
* Created a task for virtual keyboard on what I think should be improved: 
T9815
 Task 9815 "Improve touch/virtual keyboard" [Open,Normal] {KWin} https://
phabricator.kde.org/T9815
----------------------
What I want to do now:
----------------------
* Help with reviewing VD patches
* Continue work on input-method / virtual keyboard stuff
-------------------
Questions/Problems:
-------------------
* In regards to T9815, pls give input on what you think about these bullet 
points. In particular how to rearrange window content when the virtual 
keyboard is shown is a difficult one. I checked Android, which just changes 
the app size for the time the virtual keyboard is shown, what we could do as 
well. But what if there are multiple windows and what if the input focus is on 
some applet in plasma shell?
  Task 9815 is: "Improve touch/virtual keyboard" [Open,Normal] {KWin} https://
phabricator.kde.org/T9815
* My patch series on Xwayland and input redirection not being merged block me 
a bit on further work. It would be nice if after upcoming frameworks release 
we can move them forward.
* Oh, and moved gamma correction on Wayland back into backlog. reason is in 
the task T4465
Task 4465 is: "[kwin] Gamma correction" [Open,Normal] {KWin,Plasma on Wayland} 
https://phabricator.kde.org/T4465

Bhushan:
* We (KDE Community) is participating in Google code-in this year, and we have 
very less tasks currently. So if you have small Plasma related tasks for GCI, 
please sign up as mentor and add them!

Vlad:
* Fixed a visual glitch in the Zoom effect;
* Fixed a 10 years old typo in the name of _NET_WM_WINDOW_TYPE_COMBO atom, so 
now, KWin sees combobox popups as combobox popups;
* Did some cleanup in the slide effect.
Ready for review:
* Fix visual artifacts when dragging maximized windows with the Wobbly Windows 
effect being enabled; D15961
    Diff 15961 "[effects/wobblywindows] Fix visual artifacts caused by 
maximize effect" [Needs Review] https://phabricator.kde.org/D15961
* Fix jumpy transition between the in and out animation in the Sliding Popups 
effect; D15626 [1]
    Diff 15626 "[effects/slidingpopups] Fix jumpy transition between In and 
Out animations" [Needs Review] https://phabricator.kde.org/D15626
* Overhaul the Snap Helper effect. D15695
    Diff 15695 "[effects/snaphelper] Do massive overhaul" [Needs Review] 
https://phabricator.kde.org/D15695
In Progress:
* Optimize shadow generation in the Breeze decoration theme; D15514
er> Diff 15514 "[libbreezecommon] Use box blur instead of FFT blur" [Changes 
Planned] https://phabricator.kde.org/D15514
* Make the Glide and the Scale effect work with native Wayland clients. D15117
    Diff 15117 "[RFC] [effects] Make Scale and Glide effects Wayland-friendly" 
[Accepted] https://phabricator.kde.org/D15117
Todo:
* Keep closed transients above their (old) parents during animation. https://
bugs.kde.org/show_bug.cgi?id=397448 [2]
    KDE bug 397448 in kwin (core) "Deleted transients have to remember their 
parents" [normal,] https://bugs.kde.org/show_bug.cgi?id=397448
Side notes:
* Fixed a visual glitch in the Zoom effect;
* Fixed a 10 years old typo in the name of _NET_WM_WINDOW_TYPE_COMBO atom, so 
now, KWin sees combobox popups as combobox popups;
* Did some cleanup in the slide effect.
Ready for review:
* Fix visual artifacts when dragging maximized windows with the Wobbly Windows 
effect being enabled; D15961
    Diff 15961 "[effects/wobblywindows] Fix visual artifacts caused by 
maximize effect" [Needs Review] https://phabricator.kde.org/D15961
* Fix jumpy transition between the in and out animation in the Sliding Popups 
effect; D15626 [1]
    Diff 15626 "[effects/slidingpopups] Fix jumpy transition between In and 
Out animations" [Needs Review] https://phabricator.kde.org/D15626
* Overhaul the Snap Helper effect. D15695
    Diff 15695 "[effects/snaphelper] Do massive overhaul" [Needs Review] 
https://phabricator.kde.org/D15695
In Progress:
* Optimize shadow generation in the Breeze decoration theme; D15514
    Diff 15514 "[libbreezecommon] Use box blur instead of FFT blur" [Changes 
Planned] https://phabricator.kde.org/D15514
* Make the Glide and the Scale effect work with native Wayland clients. D15117
    Diff 15117 "[RFC] [effects] Make Scale and Glide effects Wayland-friendly" 
[Accepted] https://phabricator.kde.org/D15117
Todo:
* Keep closed transients above their (old) parents during animation. https://
bugs.kde.org/show_bug.cgi?id=397448 [2]
Side notes:
[1] This patch partially addresses https://bugs.kde.org/show_bug.cgi?
id=264276. In order to fix that bug, I think plasmashell has to re-use 
windows.
[2] Visually, this is how things are right now https://www.youtube.com/watch?
v=Eb2a3U7R10I and how they should be https://www.youtube.com/watch?
v=4AKu3fdrnYQ. On Wayland, things are a little bit different, but too much. 
For example, if you dismiss a popup menu, it will go behind the parent 
immediately. <zzag> [1] This patch partially addresses https://bugs.kde.org/
show_bug.cgi?id=264276. In order to fix that bug, I think plasmashell has to 
re-use windows.

Marco:
Wayland virtual desktop:
* fixed a crash in kwin which occurred when modal dialogs set on all desktops 
appeared
* modified the dbus api to remove references to x11 (and their off-by-one 
desktop numbering)
* worked around a qt bug that made the virtualdesktop kcm to close on enter 
pressed: https://bugreports.qt.io/browse/QTBUG-70934
* TODO: let's give a last push
Other:
* TODO: I want to get the multilevel kcm stuff in: i need reviews on D15098 
and D14580
Kirigami:
* work on the gallery app reorganizing to make it a training tool for 
developers
* using the work on gallery as stress test, fixed many quirks and problems:
** unified page for checkboxex/radios/switches
** a page for OverlaySheets
** a page for Drawers
** common component for the documentation Sheet
* get rid of the last QQC1 mentions
* support also Layout.preferredWidth for OverlaySheet size
* make room in OverlayDrawer footers for the bottom Action buttons if they are 
present
* in OverlayDrawer fix a bindingloop and properly dind contentWidth/Height and 
implicitWidth/Height, which reported incorrect values
* layout fixes in the top title/toolbar
* Refine how back button on Android is managed
* reorganize files of internal toolbars, put them in own folder, less 
confusion
TODO: redo the breadcrumb control, in progress

-- 
Marco Martin