D15946: Avoid creation of needless temporary containers

Alexander Volkov noreply at phabricator.kde.org
Fri Oct 5 12:03:01 BST 2018


volkov added inline comments.

INLINE COMMENTS

> broulik wrote in output.cpp:101
> The previous code also compared the contents of both, or does your new loop below do that?

Yes, the check is in the loop below: `after` and `before` are of the same sizes, and if `after` contains each key from `before`, then their keys are equal. So return false if a key can't be found in `after`.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15946

To: volkov, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181005/cf0b26f5/attachment.html>


More information about the Plasma-devel mailing list