D15946: Avoid creation of needless temporary containers

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Oct 5 08:13:06 BST 2018


broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> output.cpp:101
>  {
> -    if (before.keys() != after.keys()) {
> +    if (before.count() != after.count()) {
>          return false;

The previous code also compared the contents of both, or does your new loop below do that?

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15946

To: volkov, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181005/c82dff2a/attachment.html>


More information about the Plasma-devel mailing list