D15869: Fallback to in-process prompt if logout prompt fails

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ngraham wrote in shutdown.cpp:229
> Shutdown -> Shut Down
> 
> "Shutdown" is a noun ("The nuclear reactor is experiencing a shutdown!")
> 
> "Shut Down" is an imperative command with a verb ("Shut down the nuclear reactor!"), which is how everything else is phrased.
> 
> I will submit a patch to fix this elsewhere too, but let's also try to avoid perpetuating this grammar error in new code.

see my comment above the i18n line

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15869

To: davidedmundson, #plasma, broulik, ngraham
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181001/88ac5475/attachment.html>