D17213: Add support for settings portal

[Jan Grulich]

jgrulich marked 5 inline comments as done.
jgrulich added inline comments.

INLINE COMMENTS

> broulik wrote in khintssettings.cpp:66
> I thought Qt could de-serialize built-in types on its own?

Nope, I think it can't. You already told me this before, but from my experience I always had to do it this way.

> broulik wrote in khintssettings.cpp:79
> Can you put that into some shared header file maybe?

They don't seem to share any header file, should I put it into khintsettings.h for example and just include it in kfontsettings.h?

> broulik wrote in khintssettings.cpp:357
> Those aren't used as dbus interface names anywhere, right? (asking because of the space)

No, that's just a name of group or namespace. In kdeglobals "Toolbar style" is name of group, but I had to add some prefix to somehow identify it comes from kdeglobals, because the settings portal can be used also by Gtk apps or any other apps so it has to be clear. Gtk implementation of the settings portal use for example prefix made from GSettings scheme name.

> broulik wrote in khintssettings.cpp:442
> Would be lovely to add a `KConfig` overload to `KColorScheme::createApplicationPalette`

Ok, I'll look into that.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17213

To: jgrulich, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181129/b4aaeabc/attachment.html>