D17213: Add support for settings portal

[Kai Uwe Broulik]

broulik added a comment.


  Good stuff!

INLINE COMMENTS

> kfontsettingsdata.cpp:81
>  
> -        const KConfigGroup configGroup(mKdeGlobals, fontData.ConfigGroupKey);
> -        QString fontInfo = configGroup.readEntry(fontData.ConfigKey, QString());
> +        QString fontInfo = readConfigValue(QLatin1String(fontData.ConfigGroupKey), QLatin1String(fontData.ConfigKey));
>  

`const`

> kfontsettingsdata.cpp:131
> +
> +    if (group == QStringLiteral("org.kde.kdeglobals.General") && key == QStringLiteral("font")) {
> +        dropFontSettingsCache();

Compare with `QLatin1String`

> kfontsettingsdata.h:70
>  private:
> +    QString readConfigValue(const QString &group, const QString &key, const QString &defaultValue = QString());
> +

`const`

> khintssettings.cpp:66
> +
> +    while (!argument.atEnd()) {
> +        QString key;

I thought Qt could de-serialize built-in types on its own?

> khintssettings.cpp:79
> +
> +static inline bool checkUsePortalSupport()
> +{

Can you put that into some shared header file maybe?

> khintssettings.cpp:357
> +        }
> +    } else if (group == QStringLiteral("org.kde.kdeglobals.Toolbar style") && key == QStringLiteral("ToolButtonStyle")) {
> +        mKdeGlobalsPortal[group][key] = value.variant().toString();

Those aren't used as dbus interface names anywhere, right? (asking because of the space)

> khintssettings.cpp:442
> +        // Construct a temporary KConfig file containing color setting so we can create a KColorScheme from it
> +        QTemporaryFile file;
> +        file.open();

Would be lovely to add a `KConfig` overload to `KColorScheme::createApplicationPalette`

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17213

To: jgrulich, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181129/bbfb0b84/attachment-0001.html>