D16879: [Login and Lock screens] Improve UI elements' contrast a bit

[David Edmundson]

davidedmundson added a comment.


  Two really minor comments, but in general all seems good from my POV. 
  +1

INLINE COMMENTS

> Clock.qml:47
> +            text: Qt.formatTime(timeSource.data["Local"]["DateTime"])
> +            font.pointSize: 48 //Mockup says this, I'm not sure what to do?
> +            font.weight: Font.Light

The mockup didn't change!

Just drop the comment.

> Clock.qml:50
> +            Layout.alignment: Qt.AlignHCenter
> +            renderType: Text.QtRendering
> +        }

why?

The fact that it's in just one of two labels makes it weirder.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16879

To: ngraham, davidedmundson, #vdg, #plasma
Cc: mart, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181127/46c19ee9/attachment.html>