D17177: Drop tab-based UI for the about page
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Tue Nov 27 14:22:44 GMT 2018
leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.
It does seem that the bugAddress being an email address is a bit odd... The address given by KAboutData::bugAddress <https://api.kde.org/frameworks/kcoreaddons/html/classKAboutData.html#aae353f5b138848c71a04b903171e4c3b> can be either an email address, or a URL, though, so it might make sense to try and handle either case (something as simple as checking for :// in the string would probably work), to make the functionality here functionally equivalent to the qwidget dialogue.
At the same time, though, given that Discover's /is/ an email address... would it perhaps make sense to at least add bugs.kde.org as a link? (or, some other way of adding a secondary link for reports... though that does seem to be veering somewhat outside the scope of this particular patch)
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D17177
To: apol, #plasma, #vdg, leinir
Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181127/cba4d5ee/attachment.html>
More information about the Plasma-devel
mailing list