D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

[David Edmundson]

davidedmundson added a comment.


  I appreciate the effort to split up a big commit, but this isn't quite right.
  
  There's duplicated code changes both here and in https://phabricator.kde.org/D17020

INLINE COMMENTS

> Header.qml:285
> +    ] // states
> +    Keys.onPressed: {
> +        if (event.key == Qt.Key_Tab) {

it's very unusual to not move the actual focus on tab.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17022

To: rooty, ngraham, romangg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181120/51dc6bf5/attachment.html>