D16828: Allow sharing clipboard items to kdeconnect

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ClipboardItemDelegate.qml:32
>      property int maximumNumberOfPreviews: Math.floor(width / (units.gridUnit * 4 + units.smallSpacing))
> +    property string labelText
>      readonly property real gradientThreshold: (label.width - toolButtonsLoader.width) / label.width

What's this for?

> DelegateToolButtons.qml:30
> +    PlasmaComponents.ToolButton {
> +        iconSource: "system-run"
> +        visible: TypeRole === 0

Use `document - share` icon

> DelegateToolButtons.qml:32
> +        visible: TypeRole === 0
> +        tooltip: i18n("Invoke action")
> +        onClicked: menuItem.share(labelText)

Give it a proper tool tip, e.g. `i18n("Share")`

> Share.qml:9
> +
> +Row {
> +    id: share

Can't we just use Purpose framework for this, I'm not a huge fan of directly using KDE connect stuff here. With purpose you could also share to Pastebin and what not

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16828

To: blaws
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181111/149aa505/attachment.html>