<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16828">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16828#inline-91696">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ClipboardItemDelegate.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">maximumNumberOfPreviews:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">floor</span><span class="p">(</span><span style="color: #004012">width</span> <span style="color: #aa2211">/</span> <span class="p">(</span><span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span style="color: #601200">4</span> <span style="color: #aa2211">+</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #004012">labelText</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">readonly</span> <span style="color: #004012">property</span> <span style="color: #004012">real</span> <span style="color: #aa4000">gradientThreshold:</span> <span class="p">(</span><span style="color: #004012">label</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">-</span> <span style="color: #004012">toolButtonsLoader</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #004012">label</span><span class="p">.</span><span style="color: #004012">width</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What's this for?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16828#inline-91693">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DelegateToolButtons.qml:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">PlasmaComponents</span><span class="p">.</span><span style="color: #004012">ToolButton</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">iconSource:</span> <span style="color: #766510">"system-run"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">TypeRole</span> <span style="color: #aa2211">===</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">document - share</tt> icon</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16828#inline-91694">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DelegateToolButtons.qml:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">TypeRole</span> <span style="color: #aa2211">===</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">tooltip:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Invoke action"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">onClicked:</span> <span style="color: #004012">menuItem</span><span class="p">.</span><span style="color: #004012">share</span><span class="p">(</span><span style="color: #004012">labelText</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Give it a proper tool tip, e.g. <tt style="background: #ebebeb; font-size: 13px;">i18n("Share")</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16828#inline-91695">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Share.qml:9</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #004012">Row</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: share</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can't we just use Purpose framework for this, I'm not a huge fan of directly using KDE connect stuff here. With purpose you could also share to Pastebin and what not</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16828">https://phabricator.kde.org/D16828</a></div></div><br /><div><strong>To: </strong>blaws<br /><strong>Cc: </strong>broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>