D16768: mage global menu screen aware

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> davidedmundson wrote in appmenumodel.cpp:229
> why move this?

this patch depends on https://phabricator.kde.org/D16715 that has moved it... 
the reason is that  m_currentWindowId in current implementation is not
a current window id. it is used only for windows that delay their menu 
creation. So I renamed it in patch D16715 <https://phabricator.kde.org/D16715> to m_delayedMenuWindowId.

The m_currentWindowId needs to be set only for windows that create correctly their menus.
Maybe a better place is to place it with the setMenuHidden(false);

> davidedmundson wrote in appmenumodel.cpp:263
> can we make this
> 
> m_screenGeometry.isNull || m_screenGeom.contains(...)
> 
> so that a user can not set a screen geometry to get windows on all screens

you mean?

  setMenuHidden(info.isMinimized() || m_screenGeometry.isNull() || !m_screenGeometry.contains(info.geometry().center()));

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16768

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181109/ce7dd6e6/attachment-0001.html>