D16768: mage global menu screen aware

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> appmenumodel.cpp:85-86
> +    connect(this, &AppMenuModel::screenGeometryChanged, this, [this] {
> +        emit onWindowChanged(m_currentWindowId);
> +    });
> +

this emit keyword is confusing, you're calling a slot.

> appmenumodel.cpp:229
>  
> +        m_currentWindowId = id;
> +

why move this?

> appmenumodel.cpp:263
> +        KWindowInfo info(id, NET::WMState | NET::WMGeometry);
> +        setMenuHidden(info.isMinimized() || !m_screenGeometry.contains(info.geometry().center()));
> +    }

can we make this

m_screenGeometry.isNull || m_screenGeom.contains(...)

so that a user can not set a screen geometry to get windows on all screens

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16768

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181109/a33f7422/attachment.html>