D16651: Honor flat property of buttons

[Aleix Pol Gonzalez]

apol added a comment.


  Looks good overall.
  
  Maybe it would make sense to add a test in `tests/buttonIcons.qml`?

INLINE COMMENTS

> Button.qml:63
> +            "iconColor": controlRoot.icon && controlRoot.icon.color.a > 0? controlRoot.icon.color : Kirigami.Theme.textColor,
> +            "flat": controlRoot.flat ? controlRoot.flat : false
>          }

No need to check for `controlRoot.flat` twice

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16651

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181105/5d1ec407/attachment.html>