<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16651">View Revision</a></tr></table><br /><div><div><p>Looks good overall.</p>

<p>Maybe it would make sense to add a test in <tt style="background: #ebebeb; font-size: 13px;">tests/buttonIcons.qml</tt>?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16651#inline-90731">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Button.qml:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #766510">"iconColor"</span><span style="color: #aa2211">:</span> <span style="color: #004012">controlRoot</span><span class="p">.</span><span style="color: #004012">icon</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">controlRoot</span><span class="p">.</span><span style="color: #004012">icon</span><span class="p">.</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">a</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span style="color: #aa2211">?</span> <span style="color: #aa4000">controlRoot.icon.color :</span> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">textColor</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #766510">"iconColor"</span><span style="color: #aa2211">:</span> <span style="color: #004012">controlRoot</span><span class="p">.</span><span style="color: #004012">icon</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">controlRoot</span><span class="p">.</span><span style="color: #004012">icon</span><span class="p">.</span><span style="color: #004012">color</span><span class="p">.</span><span style="color: #004012">a</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span style="color: #aa2211">?</span> <span style="color: #aa4000">controlRoot.icon.color :</span> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Theme</span><span class="p">.</span><span style="color: #004012">textColor<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #766510">"flat"</span><span style="color: #aa2211">:</span> <span style="color: #004012">controlRoot</span><span class="p">.</span><span style="color: #004012">flat</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">controlRoot.flat :</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No need to check for <tt style="background: #ebebeb; font-size: 13px;">controlRoot.flat</tt> twice</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16651">https://phabricator.kde.org/D16651</a></div></div><br /><div><strong>To: </strong>astippich, ngraham, mart, apol, Plasma<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>