D14542: KCM using new virtual desktops DBus interface

Vlad Zagorodniy noreply at phabricator.kde.org
Thu Nov 1 20:42:55 GMT 2018


zzag added inline comments.

INLINE COMMENTS

> desktopsmodel.cpp:253
> +
> +        call.setArguments({m_desktops.last()});
> +

Is m_desktops.last() the right one? It can be already deleted.

For example, If user has two virtual desktops:

- Desktop 1
- Pizza

and he or she wants to delete virtual desktop called "Pizza", then Desktop 1 will be removed instead.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181101/03a470ea/attachment.html>


More information about the Plasma-devel mailing list