D14542: KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag requested changes to this revision.
zzag added inline comments.

INLINE COMMENTS

> desktopsmodel.cpp:413
> +        // so we can determine when we are in sync.
> +        const QString &dummyId = m_desktops.at(data.position);
> +        m_names.remove(dummyId);

Is this right?

If I remove a desktop in the KCM(without applying settings) and create a new one using the d-bus interface, the KCM will crash.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181101/b3801b1b/attachment-0001.html>