D13237: Show action.main more prominently on the ToolBarApplicationHeader

Thu May 31 14:07:06 UTC 2018

apol added a comment.

  In D13237#271434 <https://phabricator.kde.org/D13237#271434>, @ngraham wrote:

  > Love it! Two issues that I can see:
  >
  > - In this example, the text really needs to be white; it doesn't show up well against the dark green background. If the color is programmatically determined, we may need some fancy logic to choose the button's text color to ensure that it's visible enough. For that matter, the icon doesn't show up very well either...

  Yeah... thought so too. If people are not against the idea it's something to spend time on. I'm afraid it could look weird though...

  > - The button has no right padding, and touches the window edge ( A Discover issue?)

  No, still in kirigami, it's just that with a non-flat button we don't take into account the padding within the button as a margin. We can add a margin.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13237

To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180531/001bf16c/attachment-0001.html>