D13237: Show action.main more prominently on the ToolBarApplicationHeader
Nathaniel Graham
noreply at phabricator.kde.org
Thu May 31 14:03:03 UTC 2018
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Love it! Two issues that I can see:
- In this example, the text really needs to be white; it doesn't show up well against the dark green background. If the color is programmatically determined, we may need some fancy logic to choose the button's text color to ensure that it's visible enough. For that matter, the icon doesn't show up very well either...
- The button has no right padding, and touches the window edge ( A Discover issue?)
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D13237
To: apol, #kirigami, mart, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180531/f38d15b5/attachment.html>
More information about the Plasma-devel
mailing list