D13202: Circular user avatar for Kickoff

[Scott Harvey]

sharvey added a comment.


  In D13202#270585 <https://phabricator.kde.org/D13202#270585>, @ngraham wrote:
  
  > Looks great now! Quite pleasing to the eye.
  >
  > I've got a few blockers though:
  >
  > - When I change the icon in the user-manager KCM and re-open Kickoff, the new icon isn't displayed; instead I just see a blank circle with no image in it until I quit and restart plasmashell.
  
  
  That’s odd. It shows us something *is* updating, just not correctly or completely. What’s strange is that it seems to be removing the old avatar but not yet updating with the new one.

INLINE COMMENTS

> ngraham wrote in Header.qml:19
> This version bump makes Kickoff require Qt 5.11. I wasn't are that we were going to make Plasma 5.14 depend on Qt 5.11. At the minimum, it makes this hard to test without compiling your own Qt. Is there anything we're actually depending on with this patch that was added with 2.11, or can we reduce the minimum version? I manually changed it to 2.10 and didn't notice any issues...

No, that version bump was likely from an earlier attempt using a different technique  I’ll get it dialed back to the correct minimum and will repost.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180530/74919423/attachment.html>