D13148: Allow Kirigami build without KWin tablet mode dependency

Marco Martin noreply at phabricator.kde.org
Mon May 28 12:26:56 UTC 2018


mart added a comment.


  In D13148#269233 <https://phabricator.kde.org/D13148#269233>, @murillobernardes wrote:
  
  > I did not patch CMakeLists.txt because I can't test it. I could not get a system with all the right versions of all build dependencies to build Kirigami.
  >
  > On Subsurface-mobile we simply have our own integrated qmake/cmake files that builds Kirigami statically with the rest of the project.
  
  
  yeah, i know how is done... tough is it a build time or a runtime problem? there is an environment variable to force tablet mode alreeady
  
  >> Code behaves the same as not having KWin at runtime will result in both values being the exact same values as we're doing with this patch
  > 
  > So the real issue here is the new dependency on linux. Whatever way we can use to disable it is fine.
  
  what would make sense, instead a force_tablet_mode , is to make the dependency to dbus optional on all platforms

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13148

To: murillobernardes, mart, davidedmundson
Cc: davidedmundson, plasma-devel, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180528/de794ef6/attachment.html>


More information about the Plasma-devel mailing list