D13065: [Timer applet] Fix double speed countdown & commands run multiple times

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Both the compact and the fullpresentation variants of the applet had
  an instance of a timer, and both were connected to the central "running"
  flag. So if both variants had been created, there were 2 timers triggering
  the second decreasing, and also firing off the command once done.
  
  Moving the countdown timer (and at the same time also a timer for
  delayed saving of the state, which had the same issue) fixes this.
  
  BUG: 381173
  FIXED-IN: 5.12.6

TEST PLAN
  Applet still works as before on panel and background pane, now does proper
  countdown in both cases.

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixtimerdoublecount

REVISION DETAIL
  https://phabricator.kde.org/D13065

AFFECTED FILES
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180523/508b4aae/attachment.html>