D12974: Workspace KCM Code Improvement

[Furkan Tokac]

furkantokac marked 8 inline comments as done.
furkantokac added inline comments.

INLINE COMMENTS

> davidedmundson wrote in workspaceoptions.cpp:97
> We want to batch our syncs to plasmarc, which the old code did better.
> 
> I wouldn't bother trying to be clever with checking if it's the original state or not here, as KConfig will do all of that for us anyway at a more correct lower level.

Nice point. I tested the situation for the old code. When I just change single/double click option, other option files (plasmarc) are not opened. That means KConfig handles the situation. Thank you. Correction will be done now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180522/da76fc99/attachment.html>