D12974: Workspace KCM Code Improvement
Nathaniel Graham
noreply at phabricator.kde.org
Sun May 20 03:59:26 UTC 2018
ngraham added inline comments.
INLINE COMMENTS
> workspaceoptions.cpp:51
>
> -/*ConfigModule functions*/
> +// ***ConfigModule functions
> void KCMWorkspaceOptions::load()
Why all the asterisks?
> workspaceoptions.h:58
> // QML variables
> - bool m_ostateToolTip; // Original state
> - bool m_stateToolTip; // Current state
> + bool m_toolTipOriginalState; // Original state
> + bool m_toolTipCurrentState; // Current state
The inline comments are no longer needed now that the variable name is self-documenting.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D12974
To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180520/fdf4803b/attachment-0001.html>
More information about the Plasma-devel
mailing list