D12849: Improve layout of fonts kcm

Vlad Zagorodniy noreply at phabricator.kde.org
Tue May 15 12:28:39 UTC 2018


zzag added inline comments.

INLINE COMMENTS

> main.qml:34
>          id: formLayout
> -        readonly property int maxImplicitWidth: Math.max(adjustAllFontsButton.implicitWidth, Math.max(antiAliasingComboBox.implicitWidth, Math.max(excludeField.implicitWidth, Math.max(subPixelCombo.implicitWidth, hintingCombo.implicitWidth))))
> +        readonly property int maxImplicitWidth: Math.max(adjustAllFontsButton.implicitWidth, Math.max(antiAliasingComboBox.implicitWidth, Math.max(dpiSpinBox.implicitWidth, Math.max(excludeField.implicitWidth, Math.max(subPixelCombo.implicitWidth, hintingCombo.implicitWidth)))))
>  

The whole expression can be simplified: https://www.ecma-international.org/ecma-262/5.1/#sec-15.8.2.11

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: zzag, rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180515/73544409/attachment.html>


More information about the Plasma-devel mailing list