D12855: Move Widget search field to its own row so it doesn't get compressed

Nathaniel Graham noreply at phabricator.kde.org
Mon May 14 18:46:10 UTC 2018


ngraham added inline comments.

INLINE COMMENTS

> WidgetExplorer.qml:235
> +                } else {
> +                     newSearchRow.height = units.gridUnit * 2
>              }

`units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way we can derive this height value programmatically?

> WidgetExplorer.qml:264
> +
> +           // height: 0
> +            visible: heading.showingSearch

Delete code, don't comment it out.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180514/a14d860b/attachment.html>


More information about the Plasma-devel mailing list