D12698: WIP: Show SNI to install browser-side extension

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> browserlaunchwatcher.cpp:62
> +    m_browsers["google-chrome.desktop"] = chrome;
> +    m_browsers["google-chrome-unstable.desktop"] = chrome;
> +    m_browsers["chromium-browser.desktop"] = {.icon="chromium-browser", .url=QUrl("https://chrome.google.com/webstore/detail/plasma-integration/cimiefiiaegbelhefglklhhakcgmhkai")};

- There is also Beta channel https://www.google.com/chrome/browser/beta.html?platform=linux

- Each channel has its own icon.

- Designators in aggregate initialization is C++20 feature, isn't it?

- Maybe, it makes much more sense to move m_browser to an anonymous namespace, e.g.

  namespace {
  struct BrowserInfo {
      ...
  };
  
  const QHash<QString, BrowserInfo> s_browsers {
     ....
  };
  }

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma
Cc: zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180508/d62e308d/attachment.html>