<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12698">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12698#inline-65475">View Inline</a><span style="color: #4b4d51; font-weight: bold;">browserlaunchwatcher.cpp:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_browsers</span><span class="p">[</span><span style="color: #766510">"google-chrome.desktop"</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">chrome</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_browsers</span><span class="p">[</span><span style="color: #766510">"google-chrome-unstable.desktop"</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">chrome</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_browsers</span><span class="p">[</span><span style="color: #766510">"chromium-browser.desktop"</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="p">{.</span><span class="n">icon</span><span style="color: #aa2211">=</span><span style="color: #766510">"chromium-browser"</span><span class="p">,</span> <span class="p">.</span><span class="n">url</span><span style="color: #aa2211">=</span><span class="n">QUrl</span><span class="p">(</span><span style="color: #766510">"https://chrome.google.com/webstore/detail/plasma-integration/cimiefiiaegbelhefglklhhakcgmhkai"</span><span class="p">)};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ul class="remarkup-list">
<li class="remarkup-list-item">There is also Beta channel <a href="https://www.google.com/chrome/browser/beta.html?platform=linux" class="remarkup-link" target="_blank" rel="noreferrer">https://www.google.com/chrome/browser/beta.html?platform=linux</a></li>
</ul>

<ul class="remarkup-list">
<li class="remarkup-list-item">Each channel has its own icon.</li>
</ul>

<ul class="remarkup-list">
<li class="remarkup-list-item">Designators in aggregate initialization is C++20 feature, isn't it?</li>
</ul>

<ul class="remarkup-list">
<li class="remarkup-list-item">Maybe, it makes much more sense to move m_browser to an anonymous namespace, e.g.</li>
</ul>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">namespace</span> <span class="p">{</span>
<span style="color: #aa4000">struct</span> <span class="n">BrowserInfo</span> <span class="p">{</span>
    <span class="p">...</span>
<span class="p">};</span>

<span style="color: #aa4000">const</span> <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">BrowserInfo</span><span style="color: #aa2211">></span> <span class="n">s_browsers</span> <span class="p">{</span>
   <span class="p">....</span>
<span class="p">};</span>
<span class="p">}</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12698">https://phabricator.kde.org/D12698</a></div></div><br /><div><strong>To: </strong>hein, davidedmundson, apol, mart, Plasma<br /><strong>Cc: </strong>zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>