D12091: HIG entry for On-demand pattern and swipe list item

[Thomas Pfeiffer]

colomar added a comment.


  See inline comments. Otherwise it looks good!

INLINE COMMENTS

> ondemand.rst:27
> +   on-demand controls. If you need more actions, choose a different 
> +   :doc:`navigation pattern </patterns/navigation/index>`.
> +-  Only use on-demand controls, if the actions are the same for each item.

Since this is a command pattern, shouldn't this link to command patterns instead of navigation patterns?

> ondemand.rst:57
> +handle is slid back.
> +
> +

I'd add a screenshot of the swipelistitem here as well

> ondemand.rst:59
> +
> +For futher guidelines see :doc:`swip list item </components/swipelistitem>`.

swip -> swipe

REPOSITORY
  R985 KDE Human Interface Guidelines

BRANCH
  swipe

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, apol, davidedmundson, mart, hein, kamathraghavendra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180504/f6155d74/attachment-0001.html>