D12683: Guard BookmarksRunner thread use

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Krunner::match is performed in potentially multiple overlapping threads
  as a user presses each character. Qt SQL is not thread safe according to
  the docs or according to the numerous reports.
  
  It's a bit of a blind patch, ideally we should only use the database in
  the thread that opened it.
  
  This patch at least this means queries will be queued which I think will
  be enough.
  
  CCBUG: 363136

TEST PLAN
  Restarted krunner. Still saw my firefox bookmarks

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12683

AFFECTED FILES
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180503/f5d58a6f/attachment.html>