D11021: [Media controller] Add simple volume control
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Mar 27 15:56:16 UTC 2018
broulik added inline comments.
INLINE COMMENTS
> Pitel wrote in multiplexedservice.h:38
> I guess it would look more consistent if it was a job but somehow I fail to see why any of this is job in the first place: all the actions are very simple so offloading work to other thread is not needed and it hides interface in ugly way... Do you have any insight why?
That's how dataengines worked 10 years ago. I'm not a huge fan either but I'd like to keep it consistent(ly bad)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D11021
To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180327/a22bd331/attachment.html>
More information about the Plasma-devel
mailing list