D11611: Move to KRunner's second results item with a single keypress
Nathaniel Graham
noreply at phabricator.kde.org
Fri Mar 23 13:38:15 UTC 2018
ngraham created this revision.
ngraham added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.
BUG: 392197
TEST PLAN
Deployed change, killed, restarted, and activated KRunner, typed a search term
- The down arrow key now moves to the second item
- Clicked on the text field; up arrow now moved to the previous item in the results list
Activating the Open Containing Folder button for the first result via the keyboard changes slightly with this patch:
- Currently, it's down arrow > tab key
- With this patch, it's tab key three times or down arrow > shift + tab
Seems like an acceptable change to me to better support the common case of just wanting to navigate the list items
REPOSITORY
R120 Plasma Workspace
BRANCH
fix-krunner-double-down-key-issue (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11611
AFFECTED FILES
lookandfeel/contents/runcommand/RunCommand.qml
To: ngraham, #plasma, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180323/b59343dd/attachment.html>
More information about the Plasma-devel
mailing list