<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: Plasma, broulik.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11611">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.</p>

<p>BUG: 392197</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Deployed change, killed, restarted, and activated KRunner, typed a search term</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">The down arrow key now moves to the second item</li>
<li class="remarkup-list-item">Clicked on the text field; up arrow now moved to the previous item in the results list</li>
</ul>

<p>Activating the <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">Open Containing Folder</span></span></span> button for the first result via the keyboard changes slightly with this patch:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Currently, it's <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">down arrow</span></span><span style="color: #92969D;"> → </span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">tab key</span></span></span></li>
<li class="remarkup-list-item">With this patch, it's <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">tab key three times</span></span></span> or <span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">down arrow</span></span><span style="color: #92969D;"> → </span><span class="phui-tag-view phui-tag-type-shade phui-tag-grey phui-tag-shade "><span class="phui-tag-core ">shift + tab</span></span></span></li>
</ul>

<p>Seems like an acceptable change to me to better support the common case of just wanting to navigate the list items</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-krunner-double-down-key-issue (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11611">https://phabricator.kde.org/D11611</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>lookandfeel/contents/runcommand/RunCommand.qml</div></div></div><br /><div><strong>To: </strong>ngraham, Plasma, broulik<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>