D1230: GBM remote access support for KWin

Oleg Chernovskiy noreply at phabricator.kde.org
Wed Mar 21 07:02:53 UTC 2018


Kanedias requested review of this revision.
Kanedias marked an inline comment as done.
Kanedias added inline comments.

INLINE COMMENTS

> romangg wrote in drm_output.h:135
> This gives me an compile error: invalid static_cast from type 'QObject*' to type 'KWayland::Server::OutputInterface*'
> 
> I assume you can just pass m_waylandOutput as QPointer and then access data() in passBuffer. This compiled for me.

Fixed. Also removed `override` in places where it didn't compile because of it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180321/6927948a/attachment.html>


More information about the Plasma-devel mailing list