<table><tr><td style="">Kanedias requested review of this revision.<br />Kanedias marked an inline comment as done.<br />Kanedias added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1230">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-56782">View Inline</a><span style="color: #4b4d51; font-weight: bold;">romangg</span> wrote in <span style="color: #4b4d51; font-weight: bold;">drm_output.h:135</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This gives me an compile error: invalid static_cast from type 'QObject*' to type 'KWayland::Server::OutputInterface*'</p>
<p style="padding: 0; margin: 8px;">I assume you can just pass m_waylandOutput as QPointer and then access data() in passBuffer. This compiled for me.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Fixed. Also removed <tt style="background: #ebebeb; font-size: 13px;">override</tt> in places where it didn't compile because of it.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1230">https://phabricator.kde.org/D1230</a></div></div><br /><div><strong>To: </strong>Kanedias, graesslin, davidedmundson, romangg, KWin<br /><strong>Cc: </strong>jgrulich, romangg, ngraham, alexeymin, aacid, kwin, KWin, davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>