D11021: [Media controller] Add simple volume control

[Kai Uwe Broulik]

broulik added a comment.


  Mostly good!

INLINE COMMENTS

> multiplexedservice.h:38
>  
> +    Q_INVOKABLE void changeVolume(double delta, bool showOSD) {
> +        if (m_control) m_control->changeVolume(delta, showOSD);

Shouldn't this be a job? So you use the `startOperationCall` stuff used elsewhere (for e.g. Play and so on)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11021

To: Pitel, #plasma, broulik
Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180320/0394e488/attachment.html>