D11350: [AppMenuModel] Don't store actions ourselves

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Always redirect to the ones in `m_menu` in case they get deleted or otherwise altered.
  Also emit `dataChanged` when an action changes and reset the model when it gets deleted.
  This fixes the menu getting confused in LibreOffice 6 with gmenu-dbusmenu-proxy.
  
  CCBUG: 391868

TEST PLAN
  It does not fix the unresponsive/empty "File" menu item I get when running `soffice --writer` directly, needs further investigation, but the appmenu and window menu are no longer intermingled.
  It also fixes crashes (dangling pointer) I had when a menu item got removed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11350

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180315/80891a72/attachment.html>