D11195: Use separate config group for each wallpaper plugin

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause?

INLINE COMMENTS

> containmentconfigview.cpp:180
>          KConfigGroup cfg = m_containment->config();
>          cfg = KConfigGroup(&cfg, "Wallpaper");
> +        cfg = KConfigGroup(&cfg, wallpaper);

why do this line still?

> containmentconfigview.cpp:181
>          cfg = KConfigGroup(&cfg, "Wallpaper");
> +        cfg = KConfigGroup(&cfg, wallpaper);
>          m_currentWallpaperConfig = m_ownWallpaperConfig = new KDeclarative::ConfigPropertyMap(new KConfigLoader(cfg, &file), this);

when a user with a current config upgrades, what's going to happen?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11195

To: aleksejshilin, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180310/4bff908b/attachment-0001.html>