<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11195">View Revision</a></tr></table><br /><div><div><p>One could argue keeping the colour persist across wallpapers is a feature, what problems does it cause?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11195#inline-54355">View Inline</a><span style="color: #4b4d51; font-weight: bold;">containmentconfigview.cpp:180</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">KConfigGroup</span> <span class="n">cfg</span> <span style="color: #aa2211">=</span> <span class="n">m_containment</span><span style="color: #aa2211">-></span><span class="n">config</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">cfg</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">cfg</span><span class="p">,</span> <span style="color: #766510">"Wallpaper"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">cfg</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">cfg</span><span class="p">,</span> <span class="n">wallpaper</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why do this line still?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11195#inline-54356">View Inline</a><span style="color: #4b4d51; font-weight: bold;">containmentconfigview.cpp:181</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">cfg</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">cfg</span><span class="p">,</span> <span style="color: #766510">"Wallpaper"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">cfg</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">cfg</span><span class="p">,</span> <span class="n">wallpaper</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">m_currentWallpaperConfig</span> <span style="color: #aa2211">=</span> <span class="n">m_ownWallpaperConfig</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KDeclarative</span><span style="color: #aa2211">::</span><span class="n">ConfigPropertyMap</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">KConfigLoader</span><span class="p">(</span><span class="n">cfg</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">file</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">when a user with a current config upgrades, what's going to happen?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11195">https://phabricator.kde.org/D11195</a></div></div><br /><div><strong>To: </strong>aleksejshilin, Plasma, mart, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>