D11098: use opacity instead of visible

Marco Martin noreply at phabricator.kde.org
Tue Mar 6 15:57:36 UTC 2018


mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Qt documentation recomends to bind to opacity instead of visible as visible
  cascades down. The tabbar used to trigger its height behavior anim when the
  popup got hidden, binding to opacity (even if opacity isn't animated) is a
  more correct behavior.
  Plus with visible it triggers the Qt bug https://bugreports.qt.io/browse/QTBUG-66907
  which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432
  
  BUG:391432

TEST PLAN
  kickoff never opens the last tab anymore

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/kickoffover

REVISION DETAIL
  https://phabricator.kde.org/D11098

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180306/5dec3215/attachment-0001.html>


More information about the Plasma-devel mailing list