<table><tr><td style="">mart created this revision.<br />mart added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />mart requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11098">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Qt documentation recomends to bind to opacity instead of visible as visible<br />
cascades down. The tabbar used to trigger its height behavior anim when the<br />
popup got hidden, binding to opacity (even if opacity isn't animated) is a<br />
more correct behavior.<br />
Plus with visible it triggers the Qt bug <a href="https://bugreports.qt.io/browse/QTBUG-66907" class="remarkup-link" target="_blank" rel="noreferrer">https://bugreports.qt.io/browse/QTBUG-66907</a><br />
which in turn triggers <a href="https://bugs.kde.org/show_bug.cgi?id=391432" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=391432</a></p>
<p>BUG:391432</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>kickoff never opens the last tab anymore</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>phab/kickoffover</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11098">https://phabricator.kde.org/D11098</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/kickoff/package/contents/ui/FullRepresentation.qml</div></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>