D11082: [WIP] Display all StreamRestore entries in it's own config Tab

[David Rosca]

drosca added a comment.


  You forgot to add StreamRestoreTab.qml to review.
  
  > I duplicated BaseMap in map.h to use a QString key focused on the info.name property. Code duplication sucks. :/
  
  Can't you just qHash() the name and use it as integer index for normal MapBase?
  
  > Every stream uses the system notifications icon. Would need to play around with that.
  
  I don't think you can get icon name for this from pa.
  
  > Double scrollbars sucks, but I'd need to look into why there's a binding loop on AppletConfiguration.height. We need to use ScrollView + ListView so that it only loads 4-5 delegates at a time since I personally had 100+ entries (games) which took a few seconds to load the tab when I removed the filter from the Applications tab.
  
  That should only be bug in Plasma, it should work fine in kcmshell/system settings.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11082

To: Zren, #plasma
Cc: drosca, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180306/f63e19a5/attachment.html>