D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

[Kai Uwe Broulik]

broulik added a comment.


  almost good

INLINE COMMENTS

> ContextMenu.qml:122
> +                var playing = (playerData.PlaybackStatus === "Playing"),
> +                    menuItem = menu.newMenuItem(menu);
>                  menuItem.text = i18nc("Play previous track", "Previous Track");

Do two separate vars

  var playing = ...;
  var menuItem =  ...;

> ContextMenu.qml:169
> +                menuItem.enabled = Qt.binding(function() {
> +                    return playerData.PlaybackStatus !== "Stopped";
> +                });

In the media controller you do status == "playing" || status == "paused" whereas here you do status == "stopped"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11007

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180306/36c652d9/attachment.html>