D13774: [QDBusMenuBar] Guard m_window with a QPointer
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Jun 28 09:51:44 UTC 2018
broulik updated this revision to Diff 36819.
broulik added a comment.
- Always update `m_window`
`QPointer` still needed. Could be refactored to also unregister on destruction but that requires storing the `WId` separately as in `QObject::destroyed` the `~QWindow` already ran and as such `winId()` cannot be accessed
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13774?vs=36808&id=36819
REVISION DETAIL
https://phabricator.kde.org/D13774
AFFECTED FILES
src/platformtheme/qdbusmenubar.cpp
src/platformtheme/qdbusmenubar_p.h
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180628/d8a38103/attachment-0001.html>
More information about the Plasma-devel
mailing list