D13774: [QDBusMenuBar] Guard m_window with a QPointer

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  In reviewing I found a quirky bit of code:
  
    void QDBusMenuBar::handleReparent(QWindow *newParentWindow)
    {
        if (newParentWindow && newParentWindow != m_window) {
            m_window = newParentWindow
  
  if we ever got handleReparent with a nullptr, we wouldn't update our m_window. Could this be the root cause?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D13774

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180628/3bb56d41/attachment.html>