D13694: Fix wrong availability of profiles and ports.

Nicolas Fella noreply at phabricator.kde.org
Tue Jun 26 09:26:58 UTC 2018


nicolasfella added a comment.


  In D13694#283089 <https://phabricator.kde.org/D13694#283089>, @drosca wrote:
  
  > In D13694#282499 <https://phabricator.kde.org/D13694#282499>, @nicolasfella wrote:
  >
  > > This breaks the profile selection Combobox in the KCM.
  >
  >
  > How does this break that combobox? The current code is obviously wrong.
  
  
  The code for Profile is correct, the code for Port is wrong. The problem is that the values for Profile::Availability and Port:: Availability are not the same.
  Profile:
  0 : Not available
  everything else: Available
  
  Port:
  0: Unknown
  1: Not Available
  2: Available
  
  With this patch when a profile reports unavailable (0) it gets interpreted as PA_PORT_AVAILABLE_UNKNOWN and when it reports available (1) it gets interpreted as PA_PORT_AVAILABLE_NO

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13694

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180626/b1d67fb8/attachment.html>


More information about the Plasma-devel mailing list