D13596: Fix there being more security updates than total updates in notifier

[Chris Holland]

Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  We currently read the previous `m_securityCount` instead of using the current `securityCount`.
  
  BUG: 392056
  FIXED-IN 5.13.1 (or 5.13.2?)
  FIXED-IN 5.12.6 (This should be backported right?) https://github.com/KDE/discover/blame/Plasma/5.12/notifier/DiscoverNotifier.cpp#L82
  
  The bug report is from 5.12.3, and was also reported on reddit today. Both have a screenshot of the bug.
  https://bugs.kde.org/show_bug.cgi?id=392056
  https://www.reddit.com/r/kde/comments/8rzrr6/so_whats_the_logic_behind_updater/
  
  We could also start the counter at 0 and add `securityCount` afterward.
  
    -    uint count = securityUpdatesCount();
    +    uint count = 0;
         foreach(BackendNotifierModule* module, m_backends)
             count += module->updatesCount();
    +    count += securityCount;

TEST PLAN
  I haven't attempted to compile this or test it. I don't have any security updates atm anyways.
  I haven't pushed a bugfix to a `Plasma/5.__` branch before either. Do I make a separate commit for 5.12, 5.13, and master?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13596

AFFECTED FILES
  notifier/DiscoverNotifier.cpp

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180619/112cb751/attachment.html>