D6096: Add Wayland RemoteAccess capabilities to KRfb

Vlad Zagorodniy noreply at phabricator.kde.org
Mon Jun 18 19:53:11 UTC 2018


zzag added inline comments.

INLINE COMMENTS

> pw_framebuffer.h:27
> +    PWFrameBuffer(WId winid, QObject *parent = nullptr);
> +    virtual ~PWFrameBuffer() override;
> +

`virtual` is redundant. (also, it doesn't make sense to have both `virtual` and `override`)

> pw_framebufferplugin.h:36
> +   PWFrameBufferPlugin(QObject *parent, const QVariantList &args);
> +   virtual ~PWFrameBufferPlugin() override;
> +

`virtual` is redundant.

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180618/ddb46740/attachment.html>


More information about the Plasma-devel mailing list