D13573: Touchpad KCM QtQuickControls2 Conversion

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:23
>  import QtQuick.Layouts 1.3 as Layouts
>  import QtQuick.Controls.Styles 1.4 as Styles
>  

this is either unused or wrong

> main.qml:37
> +
> +    property size sizeHint: Qt.size(formLayout.width, formLayout.height)
> +    property size minimumSizeHint: Qt.size(formLayout.width/2, deviceSelector.height)

Saying the size hint is the size it currently is looks wrong

generally speaking:

width propagates from parent to child
 implicitWidth propagates from child to parent

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13573

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180616/caab7246/attachment.html>