<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13573">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13573#inline-70974">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Layouts</span> <span style="color: #601200">1.3</span> <span style="color: #004012">as</span> <span style="color: #004012">Layouts</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span><span class="p">.</span><span style="color: #004012">Styles</span> <span style="color: #601200">1.4</span> <span style="color: #004012">as</span> <span style="color: #004012">Styles</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this is either unused or wrong</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13573#inline-70975">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">property</span> <span style="color: #004012">size</span> <span style="color: #aa4000">sizeHint:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(</span><span style="color: #004012">formLayout</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #004012">formLayout</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">property</span> <span style="color: #004012">size</span> <span style="color: #aa4000">minimumSizeHint:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">size</span><span class="p">(</span><span style="color: #004012">formLayout</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">/</span><span style="color: #601200">2</span><span class="p">,</span> <span style="color: #004012">deviceSelector</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Saying the size hint is the size it currently is looks wrong</p>

<p style="padding: 0; margin: 8px;">generally speaking:</p>

<p style="padding: 0; margin: 8px;">width propagates from parent to child<br />
 implicitWidth propagates from child to parent</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13573">https://phabricator.kde.org/D13573</a></div></div><br /><div><strong>To: </strong>furkantokac, romangg, ngraham, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>